Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable level cleanup #27

Merged
merged 9 commits into from
Dec 3, 2024

Conversation

FelixPflaum
Copy link
Contributor

@FelixPflaum FelixPflaum commented Nov 29, 2024

Remove most of variable/low level stuff, including level switching from UI. The max char level is now just a const.

Change ZG enchants to their vanilla versions.
Set Recklessness to vanilla values (would fail tests otherwise for some reason lol).
Finally remove those old hunter and paladin dirs from wotlk.

@sanguinerarogue
Copy link
Contributor

Scrolled through what you have so far, looks great, cant think of any uses for the lower level stuff as long as we dont tough the casters downranking capabilities, those are all in the spell registers though.

@FelixPflaum FelixPflaum marked this pull request as ready for review December 1, 2024 17:10
Copy link
Contributor

@sanguinerarogue sanguinerarogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked over the commits since my last comment, looks good going to merge

@sanguinerarogue sanguinerarogue merged commit 04111e8 into wowsims:master Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants