Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SoD items #4

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Conversation

FelixPflaum
Copy link
Contributor

@FelixPflaum FelixPflaum commented Nov 21, 2024

Remove SoD items (everything with ID > 100000) and runes from the generated DB.
Remove/comment out item effect code for now unavailable IDs on classes.
Remove all gear presets and all but one level 60 test case per spec to make tests work.
Change effects/values in common/item_effect.go to their vanilla version.

@FelixPflaum FelixPflaum marked this pull request as ready for review November 21, 2024 12:45
Copy link
Contributor

@sanguinerarogue sanguinerarogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through, looks clean. Comfy will update the gear presets and APLs for each class next to have functioning tests with vanilla gear and skills and then we can go class by class.

Copy link
Contributor

@ericbtaylorjr ericbtaylorjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for pitching in!

@FelixPflaum FelixPflaum merged commit 3dc3731 into wowsims:master Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants