Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SoD items #4

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Remove SoD items #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
186db04
Remove SoD items and runes from DB
FelixPflaum Nov 20, 2024
cefe945
Remove SoD item code from classes
FelixPflaum Nov 20, 2024
5634c85
Replace all gear presets with blank ones, remove all but one lvl 60 t…
FelixPflaum Nov 21, 2024
59c7850
Derp, forgot to uncomment this again
FelixPflaum Nov 21, 2024
77a9302
Change item effect values to vanilla
FelixPflaum Nov 21, 2024
94cd73d
Disable MotC again for now
FelixPflaum Nov 21, 2024
b629ca8
Remove last P2+ item
FelixPflaum Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/database/db.bin
View file
Open in desktop
Binary file not shown.
5,688 changes: 1,775 additions & 3,913 deletions assets/database/db.json
View file
Open in desktop

Large diffs are not rendered by default.

Binary file modified assets/database/leftover_db.bin
View file
Open in desktop
Binary file not shown.
369 changes: 31 additions & 338 deletions assets/database/leftover_db.json
View file
Open in desktop

Large diffs are not rendered by default.

266 changes: 0 additions & 266 deletions assets/db_inputs/wowhead_rune_tooltips.csv
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion sim/common/sod/item_effects/phase_6.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func init() {
core.NewItemEffect(ObsidianChampion, func(agent core.Agent) {
character := agent.GetCharacter()
vanilla.StrengthOfTheChampionAura(character)
vanilla.EnrageAura446327(character)
//vanilla.EnrageAura446327(character)
ObsidianEdgedAura(ObsidianChampion, agent)
})

Expand Down
33 changes: 0 additions & 33 deletions sim/common/vanilla/enchant_effects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,38 +334,5 @@ func init() {
})
})

core.NewEnchantEffect(7649, func(agent core.Agent) {
character := agent.GetCharacter()
actionID := core.ActionID{SpellID: 1213833}

procSpell := character.RegisterSpell(core.SpellConfig{
ActionID: actionID,
SpellSchool: core.SpellSchoolNature,
ProcMask: core.ProcMaskEmpty,
Flags: core.SpellFlagBinary | core.SpellFlagNoOnCastComplete | core.SpellFlagPassiveSpell,

DamageMultiplier: 1,
ThreatMultiplier: 1,

ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
spell.CalcAndDealDamage(sim, target, 20, spell.OutcomeMagicHit)
},
})

character.GetOrRegisterAura(core.Aura{
Label: "Thorns +20",
Duration: core.NeverExpires,
OnReset: func(aura *core.Aura, sim *core.Simulation) {
aura.Activate(sim)
},
OnSpellHitTaken: func(aura *core.Aura, sim *core.Simulation, spell *core.Spell, result *core.SpellResult) {
if result.Landed() && spell.ProcMask.Matches(core.ProcMaskMelee) {
procSpell.Cast(sim, spell.Unit)
}
},
})
})


core.AddEffectsToTest = true
}
Loading
Loading