Prot Paladin: Tier 1 + 2 item sets #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wsphillips
commented
Sep 11, 2024
wsphillips
commented
- Added the item set bonuses for Tier 1 and Tier 2
- Updated the default gear sets + tests
- Fixed an incorrect flag on Holy Shield
22 tasks
kayla-glick
reviewed
Sep 11, 2024
kayla-glick
reviewed
Sep 11, 2024
kayla-glick
reviewed
Sep 11, 2024
kayla-glick
reviewed
Sep 11, 2024
kayla-glick
reviewed
Sep 13, 2024
Comment on lines
+198
to
+201
| // ...and does not set stacks on gain... | ||
| auras[i].OnGain = func(aura *core.Aura, sim *core.Simulation) { | ||
| paladin.AddStatDynamic(sim, stats.Block, blockBonus) | ||
| } |
There was a problem hiding this comment.
You actually might be able to avoid this completely if you change the holy shield aura OnGain code to be aura.SetStacks(aura.MaxStacks). Then setting the MaxStacks to 0 here should work hopefully? I don't know 100%
There was a problem hiding this comment.
if you try to set/remove stacks when MaxStacks = 0, you throw errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.