Bug fix: Defer calculation of Block Value's strength dependency and add Shaman SBV from strength #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
wsphillips
changed the title
kayla-glick
reviewed
Sep 21, 2024
| @@ -312,7 +312,7 @@ func NewWarrior(character *core.Character, talents string, inputs WarriorInputs) | |||
| warrior.PseudoStats.CanParry = true | |||
|
|
|||
| warrior.AddStatDependency(stats.Strength, stats.AttackPower, core.APPerStrength[character.Class]) | |||
| warrior.AddStatDependency(stats.Strength, stats.BlockValue, .05) // 20 str = 1 block | |||
| warrior.PseudoStats.BlockValuePerStrength = .05 // 20 str = 1 block | |||
There was a problem hiding this comment.
Do shamans also get this bonus?
There was a problem hiding this comment.
They should, but it looks like no one ever added the the block value/strength stat dependency in the first place! (And I glossed over it because I forgot Shamans also get it and it didn't show up when checking for usage in the repo 😅 ). I'll go ahead and tack it on here since its just one line of code.
wsphillips
changed the title
kayla-glick
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1025 by adding
PseudoStat.BlockValuePerStrengthso that we can apply theBlockValueMultiplierindependently to raw SBV and not SBV gained via strength.Shield Block Value should now be correctly computed for all classes, including UI display.