Add new 4pc TAQ ret bonus and fix Sheath #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamrch
force-pushed
the
newRet4pcTAQ
branch
from
383b324 to
7f47be5
Compare
kayla-glick
reviewed
Nov 26, 2024
Comment on lines
+467
to
+468
| exorcism.DamageMultiplierAdditive -= 0.4 * float64(oldStacks) | ||
| exorcism.DamageMultiplierAdditive += 0.4 * float64(newStacks) |
There was a problem hiding this comment.
Suggested change
| exorcism.DamageMultiplierAdditive -= 0.4 * float64(oldStacks) | |
| exorcism.DamageMultiplierAdditive += 0.4 * float64(newStacks) | |
| exorcism.DamageMultiplierAdditive += 0.4 * float64(newStacks - oldStacks) |
kayla-glick
reviewed
Nov 26, 2024
Comment on lines
+485
to
+487
| if !taq4pcAura.IsActive() { | ||
| taq4pcAura.Activate(sim) | ||
| } |
There was a problem hiding this comment.
Usually these kinds of effects will refresh every time, so you wouldn't want to make the Activate conditional
kayla-glick
reviewed
Nov 26, 2024
Comment on lines
+470
to
+472
| if newStacks == 0 { | ||
| aura.Activate(sim) | ||
| } |
There was a problem hiding this comment.
Why activate the aura when it hits zero stacks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new 4pc TAQ ret bonus
fix sheathe of light to not be fully dynamic (updates on anything that has proc mask melee)