Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new 4pc TAQ ret bonus and fix Sheath #1182

Merged
merged 1 commit into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sim/common/vanilla/item_effects.go
Original file line number Diff line number Diff line change
Expand Up @@ -1208,8 +1208,8 @@ func init() {

itemhelpers.CreateWeaponCoHProcDamage(JoonhosMercy, "Joonho's Mercy", 1.0, 20883, core.SpellSchoolArcane, 70, 0, 0, core.DefenseTypeMagic)

itemhelpers.CreateWeaponCoHProcDamage(KalimdorsRevenge, "Kalimdor's Revenge", 1.25, 1213355, core.SpellSchoolNature, 339, 138, 0, core.DefenseTypeMagic) // TODO Update PPM/scaling from PTR
itemhelpers.CreateWeaponCoHProcDamage(KalimdorsRevengeVoidTouched, "Kalimdor's Revenge", 1.25, 1213355, core.SpellSchoolNature, 339, 138, 0, core.DefenseTypeMagic) // TODO Update PPM/scaling from PTR
itemhelpers.CreateWeaponCoHProcDamage(KalimdorsRevenge, "Kalimdor's Revenge", 14, 1213355, core.SpellSchoolNature, 339, 38, 0.25, core.DefenseTypeMagic)
itemhelpers.CreateWeaponCoHProcDamage(KalimdorsRevengeVoidTouched, "Kalimdor's Revenge", 14, 1213355, core.SpellSchoolNature, 339, 38, 0.25, core.DefenseTypeMagic)

itemhelpers.CreateWeaponCoHProcDamage(LinkensSwordOfMastery, "Linken's Sword of Mastery", 1.0, 18089, core.SpellSchoolNature, 45, 30, 0, core.DefenseTypeMagic)

Expand Down Expand Up @@ -3072,6 +3072,7 @@ func BlazefuryTriggerAura(character *core.Character, spellID int32, spellSchool
Flags: core.SpellFlagNoOnCastComplete | core.SpellFlagPassiveSpell,
DamageMultiplier: 1,
ThreatMultiplier: 1,
//BonusCoefficient: 0.10,
ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
spell.CalcAndDealDamage(sim, target, damage, spell.OutcomeMagicCrit)
},
Expand Down
40 changes: 34 additions & 6 deletions sim/paladin/item_sets_pve.go
Original file line number Diff line number Diff line change
Expand Up @@ -456,12 +456,40 @@ var ItemSetAvengersRadiance = core.NewItemSet(core.ItemSet{
},
4: func(agent core.Agent) {
paladin := agent.(PaladinAgent).GetPaladin()
paladin.OnSpellRegistered(func(spell *core.Spell) {
//"S03 - Item - TAQ - Paladin - Retribution 4P Bonus",
if spell.SpellCode == SpellCode_PaladinHolyWrath || spell.SpellCode == SpellCode_PaladinConsecration || spell.SpellCode == SpellCode_PaladinExorcism || spell.SpellCode == SpellCode_PaladinHolyShock || spell.SpellCode == SpellCode_PaladinHammerOfWrath {
// 4 Set: Increases the critical strike damage bonus of your Exorcism, Holy Wrath, Holy Shock, Hammer of Wrath, and Consecration by 60%.
spell.CritDamageBonus += 0.6
}

taq4pcAura := paladin.GetOrRegisterAura(core.Aura{
Label: "Empower Exorcism",
ActionID: core.ActionID{SpellID: 415073}, // temp id
Duration: time.Second * 20,
MaxStacks: 3,
OnStacksChange: func(aura *core.Aura, sim *core.Simulation, oldStacks int32, newStacks int32) {
for _, exorcism := range paladin.exorcism {
exorcism.DamageMultiplierAdditive -= 0.4 * float64(oldStacks)
exorcism.DamageMultiplierAdditive += 0.4 * float64(newStacks)
Comment on lines +467 to +468
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exorcism.DamageMultiplierAdditive -= 0.4 * float64(oldStacks)
exorcism.DamageMultiplierAdditive += 0.4 * float64(newStacks)
exorcism.DamageMultiplierAdditive += 0.4 * float64(newStacks - oldStacks)


if newStacks == 0 {
aura.Activate(sim)
}
Comment on lines +470 to +472
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why activate the aura when it hits zero stacks?

}
},
})

paladin.RegisterAura(core.Aura{
Label: "S03 - Item - TAQ - Paladin - Retribution 4P Bonus",
Duration: core.NeverExpires,
OnReset: func(aura *core.Aura, sim *core.Simulation) {
aura.Activate(sim)
},
OnSpellHitDealt: func(aura *core.Aura, sim *core.Simulation, spell *core.Spell, result *core.SpellResult) {
if result.Landed() && spell.ProcMask.Matches(core.ProcMaskMeleeWhiteHit) {
if !taq4pcAura.IsActive() {
taq4pcAura.Activate(sim)
}
Comment on lines +485 to +487
Copy link
Collaborator

@kayla-glick kayla-glick Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually these kinds of effects will refresh every time, so you wouldn't want to make the Activate conditional

taq4pcAura.AddStack(sim)
} else if spell.SpellCode == SpellCode_PaladinExorcism {
taq4pcAura.SetStacks(sim, 0)
}
},
})
},
},
Expand Down
Loading
Loading