-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new 4pc TAQ ret bonus and fix Sheath #1182
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -456,12 +456,40 @@ var ItemSetAvengersRadiance = core.NewItemSet(core.ItemSet{ | |
}, | ||
4: func(agent core.Agent) { | ||
paladin := agent.(PaladinAgent).GetPaladin() | ||
paladin.OnSpellRegistered(func(spell *core.Spell) { | ||
//"S03 - Item - TAQ - Paladin - Retribution 4P Bonus", | ||
if spell.SpellCode == SpellCode_PaladinHolyWrath || spell.SpellCode == SpellCode_PaladinConsecration || spell.SpellCode == SpellCode_PaladinExorcism || spell.SpellCode == SpellCode_PaladinHolyShock || spell.SpellCode == SpellCode_PaladinHammerOfWrath { | ||
// 4 Set: Increases the critical strike damage bonus of your Exorcism, Holy Wrath, Holy Shock, Hammer of Wrath, and Consecration by 60%. | ||
spell.CritDamageBonus += 0.6 | ||
} | ||
|
||
taq4pcAura := paladin.GetOrRegisterAura(core.Aura{ | ||
Label: "Empower Exorcism", | ||
ActionID: core.ActionID{SpellID: 415073}, // temp id | ||
Duration: time.Second * 20, | ||
MaxStacks: 3, | ||
OnStacksChange: func(aura *core.Aura, sim *core.Simulation, oldStacks int32, newStacks int32) { | ||
for _, exorcism := range paladin.exorcism { | ||
exorcism.DamageMultiplierAdditive -= 0.4 * float64(oldStacks) | ||
exorcism.DamageMultiplierAdditive += 0.4 * float64(newStacks) | ||
|
||
if newStacks == 0 { | ||
aura.Activate(sim) | ||
} | ||
Comment on lines
+470
to
+472
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why activate the aura when it hits zero stacks? |
||
} | ||
}, | ||
}) | ||
|
||
paladin.RegisterAura(core.Aura{ | ||
Label: "S03 - Item - TAQ - Paladin - Retribution 4P Bonus", | ||
Duration: core.NeverExpires, | ||
OnReset: func(aura *core.Aura, sim *core.Simulation) { | ||
aura.Activate(sim) | ||
}, | ||
OnSpellHitDealt: func(aura *core.Aura, sim *core.Simulation, spell *core.Spell, result *core.SpellResult) { | ||
if result.Landed() && spell.ProcMask.Matches(core.ProcMaskMeleeWhiteHit) { | ||
if !taq4pcAura.IsActive() { | ||
taq4pcAura.Activate(sim) | ||
} | ||
Comment on lines
+485
to
+487
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Usually these kinds of effects will refresh every time, so you wouldn't want to make the |
||
taq4pcAura.AddStack(sim) | ||
} else if spell.SpellCode == SpellCode_PaladinExorcism { | ||
taq4pcAura.SetStacks(sim, 0) | ||
} | ||
}, | ||
}) | ||
}, | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.