Balance Druid sim updates #3
Conversation
| @@ -69,7 +69,7 @@ func (druid *Druid) applySunfire() { | |||
| NumberOfTicks: ticks, | |||
| TickLength: time.Second * 3, | |||
| OnSnapshot: func(sim *core.Simulation, target *core.Unit, dot *core.Dot, _ bool) { | |||
| dot.SnapshotBaseDamage = (baseDotDamage / float64(ticks)) + 0.13*dot.Spell.SpellPower() | |||
| dot.SnapshotBaseDamage = baseDotDamage + 0.13*dot.Spell.SpellPower() | |||
There was a problem hiding this comment.
The base damage is actually baseCalc * .65 * 4 but up above we only use baseCalc * .65. This means each tick was actually dealing 1/4 the correct damage. I opted to remove the division by # of ticks rather than multiply the base dot damage and then divide here
| TickLength: time.Second * 3, | ||
| OnSnapshot: func(sim *core.Simulation, target *core.Unit, dot *core.Dot, _ bool) { | ||
| dot.SnapshotBaseDamage = (baseDotDamage / 3.0) + spellDotCoeff*dot.Spell.SpellPower() | ||
| dot.SnapshotBaseDamage = (baseDotDamage / float64(ticks)) + spellDotCoeff*dot.Spell.SpellPower() |
There was a problem hiding this comment.
This should've been dividing by the number of ticks
kayla-glick
changed the title
| for i, suffix := range db.RandomSuffixes { | ||
| simDB.RandomSuffixes[i] = &proto.ItemRandomSuffix{ | ||
| Id: suffix.Id, | ||
| Name: suffix.Name, | ||
| Stats: suffix.Stats, | ||
| } | ||
| } |
There was a problem hiding this comment.
Suffixes needed to be loaded into the DB otherwise it would crash when using a suffix item in a test.
| faction: Faction.Alliance, | ||
| }, | ||
| { | ||
| config: AllStatsPercentBuffHorde, | ||
| picker: IconPicker, | ||
| stats: [] | ||
| stats: [], | ||
| faction: Faction.Horde, |
There was a problem hiding this comment.
Aspect of the lion being shared by two active pickers where one was hidden was causing the value to get forcibly disabled. This will filter one out all the time to prevent the issue
Add remaining timeworn ring bonuses
removed extra damage reduction code
No description provided.