Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance Druid sim updates #3

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Balance Druid sim updates #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1daafe
update moonfire+sunfire damage calculations
kayla-glick Jan 30, 2024
89611fe
update test results
kayla-glick Jan 30, 2024
3d775e0
fix issue with aspect of the lion
kayla-glick Jan 30, 2024
2b6e35b
load suffixes into the test DB, fix balance tests
kayla-glick Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sim/druid/moonfire.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ func (druid *Druid) getMoonfireBaseConfig(rank int) core.SpellConfig {
manaCost := [11]float64{0, 25, 50, 75, 105, 150, 190, 235, 280, 325, 375}[rank]
level := [11]int{0, 4, 10, 16, 22, 28, 34, 40, 46, 52, 58}[rank]

ticks := core.TernaryInt32(rank < 2, 3, 4)
impMf := float64(druid.Talents.ImprovedMoonfire)
moonfury := float64(druid.Talents.Moonfury)

Expand All @@ -40,10 +41,10 @@ func (druid *Druid) getMoonfireBaseConfig(rank int) core.SpellConfig {
Label: "Moonfire",
ActionID: core.ActionID{SpellID: spellId},
},
NumberOfTicks: core.TernaryInt32(rank < 2, 3, 4),
NumberOfTicks: ticks,
TickLength: time.Second * 3,
OnSnapshot: func(sim *core.Simulation, target *core.Unit, dot *core.Dot, _ bool) {
dot.SnapshotBaseDamage = (baseDotDamage / 3.0) + spellDotCoeff*dot.Spell.SpellPower()
dot.SnapshotBaseDamage = (baseDotDamage / float64(ticks)) + spellDotCoeff*dot.Spell.SpellPower()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should've been dividing by the number of ticks

dot.SnapshotAttackerMultiplier = 1 // dot.Spell.AttackerDamageMultiplier(dot.Spell.Unit.AttackTables[target.UnitIndex])
},
OnTick: func(sim *core.Simulation, target *core.Unit, dot *core.Dot) {
Expand Down
2 changes: 1 addition & 1 deletion sim/druid/runes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (druid *Druid) applySunfire() {
NumberOfTicks: ticks,
TickLength: time.Second * 3,
OnSnapshot: func(sim *core.Simulation, target *core.Unit, dot *core.Dot, _ bool) {
dot.SnapshotBaseDamage = (baseDotDamage / float64(ticks)) + 0.13*dot.Spell.SpellPower()
dot.SnapshotBaseDamage = baseDotDamage + 0.13*dot.Spell.SpellPower()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base damage is actually baseCalc * .65 * 4 but up above we only use baseCalc * .65. This means each tick was actually dealing 1/4 the correct damage. I opted to remove the division by # of ticks rather than multiply the base dot damage and then divide here

image

dot.SnapshotAttackerMultiplier = 1
},
OnTick: func(sim *core.Simulation, target *core.Unit, dot *core.Dot) {
Expand Down
Loading