Merge pull request #3940 from grzpra/feature/sw-fix

Fix Shield Wall damage reduction (&update tests)
wowsims · Oct 25, 2023 · d944ccf · d944ccf
2 parents 1d77eb5 + 7955546
commit d944ccf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/sim/warrior/protection/TestProtectionWarrior.results b/sim/warrior/protection/TestProtectionWarrior.results
@@ -46,7 +46,7 @@ character_stats_results: {
 stat_weights_results: {
  key: "TestProtectionWarrior-StatWeights-Default"
  value: {
-  weights: 1.01803
+  weights: 0.84402
   weights: 0
   weights: 0
   weights: 0
@@ -57,7 +57,7 @@ stat_weights_results: {
   weights: 0
   weights: 0
   weights: 0
-  weights: 0.19691
+  weights: 0.26128
   weights: 0
   weights: 0
   weights: 0
@@ -66,12 +66,12 @@ stat_weights_results: {
   weights: 0
   weights: 0
   weights: 0
-  weights: 0.02012
+  weights: 0.01763
   weights: 0
   weights: 0
   weights: 0
-  weights: 0.42911
-  weights: 0.07235
+  weights: 0.4296
+  weights: 0.02365
   weights: 0
   weights: 0
   weights: 0
@@ -921,9 +921,9 @@ dps_results: {
 dps_results: {
  key: "TestProtectionWarrior-Average-Default"
  value: {
-  dps: 2772.35319
-  tps: 6734.95331
-  dtps: 127.69906
+  dps: 2771.43209
+  tps: 6732.50018
+  dtps: 127.46896
  }
 }
 dps_results: {

diff --git a/sim/warrior/shield_wall.go b/sim/warrior/shield_wall.go
@@ -15,7 +15,7 @@ func (warrior *Warrior) RegisterShieldWallCD() {
 	duration := time.Second*12 + core.TernaryDuration(warrior.HasSetBonus(ItemSetDreadnaughtPlate, 4), time.Second*3, 0)
 	hasGlyph := warrior.HasMajorGlyph(proto.WarriorMajorGlyph_GlyphOfShieldWall)
 	//This is the inverse of the tooltip since it is a damage TAKEN coefficient
-	damageTaken := core.TernaryFloat64(hasGlyph, 0.4, 0.6)
+	damageTaken := core.TernaryFloat64(hasGlyph, 0.6, 0.4)
 
 	actionID := core.ActionID{SpellID: 871}
 	swAura := warrior.RegisterAura(core.Aura{