Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): PDE-5719 split FieldSchema into InputFieldSchema, OutputFieldSchema, and AuthFieldSchema #957

Merged
merged 61 commits into from
Feb 4, 2025

Conversation

Natay
Copy link
Contributor

@Natay Natay commented Jan 28, 2025

https://zapierorg.atlassian.net/browse/PDE-5719

This pull request addresses the need to split the existing FieldSchema into three separate schemas: InputFieldSchema, OutputFieldSchema, and AuthFieldSchema. This change enhances the modularity and clarity of the schema definitions, making it easier to manage and extend them in the future for other use cases ( Agents, Canvas, unFurl )

@Natay Natay requested a review from kola-er January 28, 2025 20:21
@Natay
Copy link
Contributor Author

Natay commented Jan 28, 2025

@kola-er I addressed the changes and this is ready for a re-review, I am going to add some unit tests before taking it out of draft!

@kola-er
Copy link
Contributor

kola-er commented Jan 29, 2025

@Natay Looking close, thank you. I left some comments. Also, with both FieldsSchema and DynamicFieldsSchema not being used anymore, I think they can be deleted.

@Natay Natay requested a review from kola-er January 29, 2025 16:06
@kola-er
Copy link
Contributor

kola-er commented Feb 4, 2025

@Natay Please git squash all the commits into 1 commit of "Split FieldSchema into AuthFieldSchema, InputFieldSchema, OutputFieldSchema"

@Natay
Copy link
Contributor Author

Natay commented Feb 4, 2025

@kola-er I plan on squashing before merging if that's okay!
Screenshot 2025-02-04 at 8 26 08 AM

@Natay Natay requested a review from kola-er February 4, 2025 13:36
@Natay Natay requested a review from kola-er February 4, 2025 14:00
Copy link
Contributor

@kola-er kola-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort. Looks good to go.

@Natay
Copy link
Contributor Author

Natay commented Feb 4, 2025

Thank you for all the guidance here @kola-er @FokkeZB !

@Natay Natay merged commit a6f4867 into zapier-platform-major-release-17.0.0-dev Feb 4, 2025
14 checks passed
@Natay Natay deleted the PDE-5719 branch February 4, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants