-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schema): PDE-5719 split FieldSchema into InputFieldSchema, OutputFieldSchema, and AuthFieldSchema #957
Conversation
@kola-er I addressed the changes and this is ready for a re-review, I am going to add some unit tests before taking it out of draft! |
@Natay Looking close, thank you. I left some comments. Also, with both |
@Natay Please git squash all the commits into 1 commit of "Split FieldSchema into AuthFieldSchema, InputFieldSchema, OutputFieldSchema" |
Co-authored-by: Kola Erinoso <[email protected]>
Co-authored-by: Kola Erinoso <[email protected]>
Co-authored-by: Kola Erinoso <[email protected]>
Co-authored-by: Kola Erinoso <[email protected]>
Co-authored-by: Kola Erinoso <[email protected]>
Co-authored-by: Kola Erinoso <[email protected]>
Co-authored-by: Kola Erinoso <[email protected]>
Co-authored-by: Kola Erinoso <[email protected]>
@kola-er I plan on squashing before merging if that's okay! |
Co-authored-by: Kola Erinoso <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort. Looks good to go.
a6f4867
into
zapier-platform-major-release-17.0.0-dev
https://zapierorg.atlassian.net/browse/PDE-5719
This pull request addresses the need to split the existing FieldSchema into three separate schemas: InputFieldSchema, OutputFieldSchema, and AuthFieldSchema. This change enhances the modularity and clarity of the schema definitions, making it easier to manage and extend them in the future for other use cases ( Agents, Canvas, unFurl )