Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): PDE-5719 split FieldSchema into InputFieldSchema, OutputFieldSchema, and AuthFieldSchema #957

Merged
merged 61 commits into from
Feb 4, 2025
+1,721 −770
Merged

feat(schema): PDE-5719 split FieldSchema into InputFieldSchema, OutputFieldSchema, and AuthFieldSchema #957

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
fd594f3
first attempt: split FieldSchema
Natay Jan 28, 2025
19b3125
PDE-5719 address PR comments
Natay Jan 28, 2025
6ebe53c
PDE-5719 address commented out lines
Natay Jan 28, 2025
879dd06
PDE-5719 address commented out lines
Natay Jan 28, 2025
a834d51
PDE-5719 clean up
Natay Jan 28, 2025
de4d6a2
PDE-5719 clean up
Natay Jan 29, 2025
215c3ea
rename to AuthFieldSchema
Natay Jan 29, 2025
ec60ed4
PR suggestions: remove cleanErrors addition
Natay Jan 29, 2025
3018bde
PR suggestions: add examples and anti-examples
Natay Jan 29, 2025
9354f50
fix description
Natay Jan 29, 2025
eee329e
remove FieldsSchema and DynamicFieldsSchema
Natay Jan 29, 2025
833bd10
add unit tests
Natay Jan 29, 2025
e89a3b8
update unit test
Natay Jan 29, 2025
eb2c904
Update packages/schema/lib/schemas/AuthFieldSchema.js
Natay Jan 29, 2025
0fa07cf
Update packages/schema/lib/schemas/AuthFieldSchema.js
Natay Jan 29, 2025
c121fc9
Update packages/schema/lib/schemas/AuthFieldSchema.js
Natay Jan 29, 2025
3ffcfa8
Update packages/schema/lib/schemas/AuthFieldsSchema.js
Natay Jan 29, 2025
e0651f1
Update packages/schema/lib/schemas/AuthFieldsSchema.js
Natay Jan 29, 2025
c371dc4
Update packages/schema/lib/schemas/AuthFieldsSchema.js
Natay Jan 29, 2025
3f50efe
Update packages/schema/lib/schemas/AuthFieldsSchema.js
Natay Jan 29, 2025
7260e55
Update packages/schema/lib/schemas/AuthFieldsSchema.js
Natay Jan 29, 2025
09e53fd
run yarn build
Natay Jan 29, 2025
6ed5ac8
PR suggestion: move isSafe check as a functional-contsraint
Natay Jan 29, 2025
387a7f5
update test
Natay Jan 29, 2025
78c1d79
Update packages/schema/test/index.js
Natay Jan 30, 2025
e5f22b3
Update packages/schema/test/index.js
Natay Jan 30, 2025
03cdb16
Update packages/schema/test/index.js
Natay Jan 30, 2025
e02fa4c
Update packages/schema/lib/utils/makeValidator.js
Natay Jan 30, 2025
a844f03
Update packages/schema/lib/functional-constraints/AuthFieldisSafe.js
Natay Jan 30, 2025
a6d3e90
Update packages/schema/lib/functional-constraints/AuthFieldisSafe.js
Natay Jan 30, 2025
6c75d36
Update packages/schema/lib/functional-constraints/AuthFieldisSafe.js
Natay Jan 30, 2025
91622cd
Update packages/schema/lib/functional-constraints/AuthFieldisSafe.js
Natay Jan 30, 2025
81ba9ce
Update packages/schema/lib/functional-constraints/AuthFieldisSafe.js
Natay Jan 30, 2025
298e148
Update packages/schema/lib/functional-constraints/AuthFieldisSafe.js
Natay Jan 30, 2025
dc34ca2
update FORBIDDEN_KEYS to match secret scrubber
Natay Jan 30, 2025
128f8e9
PR suggestions: tailor fields to not inherit from FieldSchema
Natay Jan 31, 2025
55284c0
run yarn build
Natay Jan 31, 2025
449486e
PR suggestions: remove uneeded fields and fix tests
Natay Jan 31, 2025
7016f01
PR suggestion:rename to isNotSecret
Natay Jan 31, 2025
22059ff
pull from dev branch
Natay Jan 31, 2025
8065bcf
PDE-5719 add helpText back to inputField
Natay Feb 3, 2025
6437724
update type enums for better fit
Natay Feb 3, 2025
ea1ef6c
apply PR suggestions
Natay Feb 3, 2025
e8e8db5
apply PR suggestions
Natay Feb 3, 2025
e8fa2df
remove copy from auth types
Natay Feb 3, 2025
2dbcbb1
add default back to input and output schema
Natay Feb 3, 2025
83e6d7d
update docs
Natay Feb 3, 2025
51bc727
apply PR suggestions
Natay Feb 3, 2025
04aa8e6
apply PR suggestions
Natay Feb 3, 2025
34ec873
PR suggestion: use common fields and update schemas
Natay Feb 3, 2025
a94f3ac
Update packages/schema/lib/functional-constraints/AuthFieldisSafe.js
Natay Feb 4, 2025
ec31b8f
Update packages/schema/lib/schemas/AuthFieldSchema.js
Natay Feb 4, 2025
edae9ea
Update packages/schema/lib/schemas/OutputFieldSchema.js
Natay Feb 4, 2025
f6ca550
Update packages/schema/test/index.js
Natay Feb 4, 2025
8a6387e
Update packages/schema/lib/schemas/FieldSchema.js
Natay Feb 4, 2025
de4e209
Update packages/schema/lib/schemas/AuthFieldSchema.js
Natay Feb 4, 2025
7bfc4a0
Update packages/schema/lib/schemas/AuthFieldSchema.js
Natay Feb 4, 2025
ca8c94f
Update packages/schema/lib/schemas/InputFieldSchema.js
Natay Feb 4, 2025
58ceac2
Split FieldSchema into AuthFieldSchema, InputFieldSchema, OutputField…
Natay Feb 4, 2025
dfc3dc5
add examples/anti-examples back for FieldSchema
Natay Feb 4, 2025
fb88e82
Update packages/schema/lib/schemas/AuthFieldSchema.js
Natay Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/tests/utils/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe('build (runs slowly)', function () {
smartPaths.filter((p) => p.endsWith('.ts')).length.should.equal(0);
smartPaths.should.not.containEql('tsconfig.json');

smartPaths.length.should.be.within(200, 301);
smartPaths.length.should.be.within(200, 303);
Natay marked this conversation as resolved.
Show resolved Hide resolved
});

it('should list all the files', () => {
Expand Down
Loading