Skip to content

Commit

Permalink
Add stageBarrier helpers for future refactors
Browse files Browse the repository at this point in the history
This will be helpful because a lot of our barriers can be much simpler
with no extra cost.
  • Loading branch information
zeux committed Dec 22, 2024
1 parent bb6d3c4 commit ad5c59e
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
19 changes: 19 additions & 0 deletions src/resources.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,25 @@ void pipelineBarrier(VkCommandBuffer commandBuffer, VkDependencyFlags dependency
vkCmdPipelineBarrier2(commandBuffer, &dependencyInfo);
}

void stageBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags2 stageMask)
{
stageBarrier(commandBuffer, stageMask, stageMask);
}

void stageBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags2 srcStageMask, VkPipelineStageFlags2 dstStageMask)
{
VkMemoryBarrier2 barrier = { VK_STRUCTURE_TYPE_MEMORY_BARRIER_2 };
barrier.srcStageMask = srcStageMask;
barrier.dstStageMask = dstStageMask;
barrier.srcAccessMask = barrier.dstAccessMask = VK_ACCESS_MEMORY_READ_BIT | VK_ACCESS_MEMORY_WRITE_BIT;

VkDependencyInfo dependencyInfo = { VK_STRUCTURE_TYPE_DEPENDENCY_INFO };
dependencyInfo.memoryBarrierCount = 1;
dependencyInfo.pMemoryBarriers = &barrier;

vkCmdPipelineBarrier2(commandBuffer, &dependencyInfo);
}

static uint32_t selectMemoryType(const VkPhysicalDeviceMemoryProperties& memoryProperties, uint32_t memoryTypeBits, VkMemoryPropertyFlags flags)
{
for (uint32_t i = 0; i < memoryProperties.memoryTypeCount; ++i)
Expand Down
3 changes: 3 additions & 0 deletions src/resources.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ VkBufferMemoryBarrier2 bufferBarrier(VkBuffer buffer, VkPipelineStageFlags2 srcS

void pipelineBarrier(VkCommandBuffer commandBuffer, VkDependencyFlags dependencyFlags, size_t bufferBarrierCount, const VkBufferMemoryBarrier2* bufferBarriers, size_t imageBarrierCount, const VkImageMemoryBarrier2* imageBarriers);

void stageBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags2 stageMask);
void stageBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags2 srcStageMask, VkPipelineStageFlags2 dstStageMask);

void createBuffer(Buffer& result, VkDevice device, const VkPhysicalDeviceMemoryProperties& memoryProperties, size_t size, VkBufferUsageFlags usage, VkMemoryPropertyFlags memoryFlags);
void uploadBuffer(VkDevice device, VkCommandPool commandPool, VkCommandBuffer commandBuffer, VkQueue queue, const Buffer& buffer, const Buffer& scratch, const void* data, size_t size);
void destroyBuffer(const Buffer& buffer, VkDevice device);
Expand Down

0 comments on commit ad5c59e

Please sign in to comment.