-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add urdf generated with cad and onshape to robot #94
Conversation
|
maybe we also want a urdf for both versions of the robot until we merge it into a single robot? which we should probably do soon? |
most of them were not on the repo
do you want to do it?
I think we can stay with this version until we converge on one single version as (as far as I know) you don't need the urdf of your version for now. It's a bit of work to generate it and if you don't really need it I would prefer not to do it :) |
motor mount, motor arm and shaft collar are already in the repo? de-deplicate and put all stls in the same place under
yes will do after you merge
how long would it take? I'd be interested in using this as comparison against a learned sim. |
@Armandpl I simplified the urdf by merging stls from same link together. I also deleted the stls I had created that where unused. So in the end I add only 3 new stls to the repo (to visualize the 3 links), the rest is just reorganizing stls by v1/v2/clamp. |
the reason you need extra stls is to include stuff we don't print e.g the encoder? this is for visualization only and the sim could work without it? |
Yes exactly, and rather than adding all the missing parts' STLs individually I just add 3 merged STLs for the 3 body link
Yes
It is feasible, my concern is that it will make the urdf very long and messy. Visualization may also be faster with only 3 STLs to display. Notice that I ran a pass of simplification in my last commit to make them a bit lighter.
It will be cleaner the day we have only one design of course. We will have a folder for the printable parts' STLs but I will still need my 3 merged STLs for visualization. |
closes #93
Add an urdf of the robot (v2) generated with onshape-to-robot