Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add urdf generated with cad and onshape to robot #94

Merged
merged 6 commits into from
Jan 26, 2025
Merged

Conversation

pierfabre
Copy link
Collaborator

closes #93

Add an urdf of the robot (v2) generated with onshape-to-robot

@pierfabre pierfabre requested a review from Armandpl October 19, 2024 22:46
@pierfabre pierfabre self-assigned this Oct 19, 2024
@Armandpl
Copy link
Owner

  • why do we need new stls? Can't we use those already in the repo?
  • we also want to migrate to git lfs for CAD files. now might be a good time? We want to rewrite the git history/use git lfs migrate to make sure we remove current files from the history

@Armandpl
Copy link
Owner

maybe we also want a urdf for both versions of the robot until we merge it into a single robot? which we should probably do soon?

@pierfabre
Copy link
Collaborator Author

  • why do we need new stls? Can't we use those already in the repo?

most of them were not on the repo

  • we also want to migrate to git lfs for CAD files. now might be a good time? We want to rewrite the git history/use git lfs migrate to make sure we remove current files from the history

do you want to do it?

maybe we also want a urdf for both versions of the robot until we merge it into a single robot? which we should probably do soon?

I think we can stay with this version until we converge on one single version as (as far as I know) you don't need the urdf of your version for now. It's a bit of work to generate it and if you don't really need it I would prefer not to do it :)

@Armandpl
Copy link
Owner

most of them were not on the repo

motor mount, motor arm and shaft collar are already in the repo? de-deplicate and put all stls in the same place under /hardware/CAD/stls. I think we should have a to_print directory for printable stls and a other/hardware (not sure how to name it) directory for the rest.

do you want to do it?

yes will do after you merge

if you don't really need it I would prefer not to do it :)

how long would it take? I'd be interested in using this as comparison against a learned sim.

@Armandpl Armandpl marked this pull request as draft November 8, 2024 21:22
@pierfabre pierfabre marked this pull request as ready for review January 25, 2025 13:03
@pierfabre
Copy link
Collaborator Author

@Armandpl I simplified the urdf by merging stls from same link together. I also deleted the stls I had created that where unused. So in the end I add only 3 new stls to the repo (to visualize the 3 links), the rest is just reorganizing stls by v1/v2/clamp.

@Armandpl
Copy link
Owner

Armandpl commented Jan 25, 2025

the reason you need extra stls is to include stuff we don't print e.g the encoder? this is for visualization only and the sim could work without it?
what are the steps to go from this to using the printable stls + extra stls for non printable parts instead of the "merged" stls? good to merge if it's very clear how we'll clean this up.

@pierfabre
Copy link
Collaborator Author

the reason you need extra stls is to include stuff we don't print e.g the encoder?

Yes exactly, and rather than adding all the missing parts' STLs individually I just add 3 merged STLs for the 3 body link

this is for visualization only and the sim could work without it?

Yes

what are the steps to go from this to using the printable stls + extra stls for non printable parts instead of the "merged" stls?

It is feasible, my concern is that it will make the urdf very long and messy. Visualization may also be faster with only 3 STLs to display. Notice that I ran a pass of simplification in my last commit to make them a bit lighter.

good to merge if it's very clear how we'll clean this up.

It will be cleaner the day we have only one design of course. We will have a folder for the printable parts' STLs but I will still need my 3 merged STLs for visualization.

@pierfabre pierfabre merged commit cd9c1a7 into master Jan 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate an urdf of the robot
2 participants