-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Listener to PreAssetsCompileEvent #22
Add Listener to PreAssetsCompileEvent #22
Conversation
9ab7aa2
to
7cdba96
Compare
The |
I see it. Could we surround that with a method_exists? Would that do it? public function getPublicFilesystemPath(): string
{
if (!method_exists($this->decorator', 'getPublicFilesystemPath')) {
throw new \Exception('...');
}
// rest of method
} |
Damm didn't know about this trick to fool phpstan! Thanks! 😁 |
@bocharsky-bw I do not have the right to merge this PR, and I think this is ready to go 😁 |
Sorry for the delay, I hoped for @weaverryan final review on it. Thanks! |
->set('sass.public_asset_path_resolver', SassPublicPathAssetPathResolver::class) | ||
->decorate('asset_mapper.public_assets_path_resolver') | ||
->args([ | ||
service('.inner') | ||
]) | ||
|
||
->set('sass.listener.pre_assets_compile', PreAssetsCompileEventListener::class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The argument is missing:
->args([
service('sass.builder')
])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds valid. Would you like to create a PR?
//cc @WebMamba
No description provided.