Various updates to ICD 11 prefix record #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
changed the title
|
Need help with that error! |
cthoyt
reviewed
Jan 11, 2025
| @@ -53913,7 +53916,7 @@ | |||
| "name": "Charles Tapley Hoyt", | |||
| "orcid": "0000-0003-4423-4370" | |||
| }, | |||
| "description": "ICD11 codes, which typically appear in health records and can be used for post-coordination", | |||
| "description": "An ICD-11 code is a standardized alphanumeric identifier used to classify and document diseases, conditions, and health-related issues for global healthcare and statistical purposes.", | |||
There was a problem hiding this comment.
can you please give some more context?
Who uses ICD11 codes, and where? Why do they exist as a counterpart to ICD11 identifiers, which have URIs and everything, but these don't?
cthoyt
reviewed
Jan 11, 2025
|
@matentzn I added a comment for follow-up, I think that it would be a missed opportunity not to make the descriptions much more detailed and useful for non-ICD-insiders. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
==========================================
+ Coverage 42.51% 46.59% +4.08%
==========================================
Files 117 118 +1
Lines 8327 8292 -35
Branches 1963 1363 -600
==========================================
+ Hits 3540 3864 +324
+ Misses 4582 4241 -341
+ Partials 205 187 -18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to say that this is a compromise I can just tolerate, but I don't really like it. The choice of having
icd11,ICD-11andICD11be associated with the foundation component strikes me as questionable (but I also don't know for sure if this is wrong, else I would insist). What I really do not like is to haveicd11being the default prefix for the icd11 foundation, rather than the much less ambiguousicd11.foundation.I would say, lets not do any more damage now, this PR will satisfy our immediate needs, but IMO we should just have the icd11 team itself decide what they want. I know them all quite well, and will reach out now to see what they say.