-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add initial support for BELs chains #70
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatecat
reviewed
Apr 26, 2021
fpga_interchange/nextpnr.py
Outdated
assert len(refs_and_labels) == len(self.refs) | ||
assert len(refs_and_labels) == len(self.labels) | ||
for ref in refs_and_labels: | ||
if ref not in self.refs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be simplified to assert ref in self.refs, ref
?
gatecat
reviewed
Apr 26, 2021
gatecat
reviewed
Apr 26, 2021
a6f3271
to
3d4ab17
Compare
3 tasks
c3273de
to
e6e1494
Compare
Signed-off-by: Jan Kowalewski <[email protected]>
Signed-off-by: Jan Kowalewski <[email protected]>
Signed-off-by: Jan Kowalewski <[email protected]>
Signed-off-by: Alessandro Comodi <[email protected]>
e6e1494
to
bce222b
Compare
Superseeded by #91, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial version of BELs chains support. This is related to SymbiFlow/nextpnr#262
The main target for now is to get carry chains support for xilinx architectures, but the solution should be applicable for any architecture in the end. The PR includes what type of data we should pass to nextpnr in order to get the constraining step done of the BELs chains.
Signed-off-by: Jan Kowalewski [email protected]