Upgrade to React@18 #209337
Merged
Upgrade to React@18 #209337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
Dosant
added
ci:cloud-deploy
|
Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/290 |
6 tasks
6 tasks
29 tasks
18 tasks
6 tasks
21 tasks
9 tasks
6 tasks
2 tasks
…act18-merge # Conflicts: # x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components/src/exception_item_card/conditions/entry_content/__snapshots__/entry_content.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/timelines/components/netflow/__snapshots__/index.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/body/renderers/netflow/__snapshots__/netflow_row_renderer.test.tsx.snap # yarn.lock
This was referenced Feb 13, 2025
Closed
7 tasks
4 tasks
12 tasks
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Async chunks
Page load bundle
History
|
Dosant
added
release_note:skip
6 tasks
botelastic
bot
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
delanni
approved these changes
Mar 3, 2025
|
Admin merged upon request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades React packages to version 18, while keeping Kibana running in Legacy mode (
ReactDOM.render). This is the first phase of the React@18 upgrade; the second phase will gradually migrate Kibana to Concurrent mode (createRoot) (exact plan is tbd).Upgrade is intended to be non-breaking and behave just like React@17, but it still requires thorough testing from all teams that own UI to discover any potential critical UI issues. The testing was done in #203114.
Most of the breaking work was completed in previous PRs and this PR only includes minor breaking jest tests tweaks / snapshots updates
Backports:
Risks
Kibana’s UI functional tests coverage and significant manual testing that was done by a lot of teams in #203114 gives us a lot of confidence.
However, since this was a large internal change for React they still could be issues hidden in "remote" parts of UIs, think of blank screens, error splash screens, unresponsive pages, new errors in the console, unpredictable UI behavior (like laggy text inputs that skip letters when typing fast).