Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use new CA topics instead of actuator_controls/outputs #208

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sfuhrer
Copy link
Collaborator

@sfuhrer sfuhrer commented Nov 24, 2022

  • change how flight time calculation is done: use vehicle_land_detected instead of PWM thresholds
  • OR, what we need for the current work about maneuver-based ID: manually selected start/end points for a maneuver
  • use vehicle_torque_setpoint and vehicle_torque_setpoint instead of actuator_outputs for --> this is fine for FW, where every actuator is controlling one axis (not true for roll though with 2 ailerons). Better would be to use actuator_motors, actuator_servos, but I didn't get it working with that. Also, actuator_motors/_servos is logged at a much lower rate, so we may want to add them to the PX4 high rate logging profile and enable that for Sys-ID flights

Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change how flight time calculation is done: use vehicle_land_detected instead of PWM thresholds
OR, what we need for the current work about maneuver-based ID: manually selected start/end points for a maneuver

I think we would want to support both use cases

Currently already supported:

  • System ID from a normal flight (and reject it if the data is not informative enough)
  • User can interactively choose which data to use

The missing use case currently in this repository is:

  • In case we did a maneuver, use only that section of the log for ID.

If we are to support the maneuver based ID, I think we just lack the instrumentation on PX4 side to log this. Would you have any ideas where should we put this? Maybe just a hacky manually activated switch for now?

@sfuhrer
Copy link
Collaborator Author

sfuhrer commented Nov 25, 2022

Would you have any ideas where should we put this? Maybe just a hacky manually activated switch for now?

I was thinking the same yes. AUX1 or AUX2 for example. Would be quite straight forward and not even require code changes.

@Jaeyoung-Lim
Copy link
Member

@sfuhrer I guess we don't need this anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants