Don't cache the checker healthcheck endpoint #468
Merged
+11
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
force-pushed
the
jsh/do-not-cache-healthcheck
branch
2 times, most recently
from
2dbf7af to
be905fc
Compare
simonbyford
reviewed
Jul 31, 2024
There was a problem hiding this comment.
This seems like a reasonable change. Unfortunately when I deployed the change to CODE, I was greeted by this error:
https://checker.typerighter.code.dev-gutools.co.uk/rules
I appreciate it's been a while since you proposed this change. Do you remember seeing anything like this in your testing?
|
Thanks for testing thoroughly! I'll revisit this PR soon. |
Merged
jonathonherbert
force-pushed
the
jsh/do-not-cache-healthcheck
branch
from
be905fc to
387ef20
Compare
|
... for a given value of |
rhystmills
approved these changes
Jan 23, 2025
jonathonherbert
force-pushed
the
jsh/do-not-cache-healthcheck
branch
from
76fef75 to
e959a14
Compare
jonathonherbert
force-pushed
the
jsh/do-not-cache-healthcheck
branch
from
e959a14 to
aca4db0
Compare
prout-bot
added
Pending-on-Checker
Pending-on-Rule Manager
Seen-on-Rule Manager
and removed
Pending-on-Rule Manager
labels
|
Seen on Rule Manager (merged by @jonathonherbert 10 minutes and 39 seconds ago) Please check your changes! |
|
Overdue on Checker (merged by @jonathonherbert 15 minutes and 6 seconds ago) What's gone wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Don't use caching for the Checker service, to enable the lovely Prout-bot to do its work (#465.)
We use Cloudfront to improve service latency for global users by removing TCP slowstart and reducing TLS handshake latency – we don't care about caching content.
(Initially this PR just removed caching for the healthcheck endpoint (620eb37), but on reflection I think removing caching entirely is more appropriate.)
How to test
Deploy to CODE or PROD. You should no longer see
X-Cache: Hit from cloudfrontheaders on requests.