Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

294: Improve breaks and bins for probability chart #33

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cincodenada
Copy link

For probability, I think breaks of 25 are more natural, and that
revealed that the bin at 50 was 45-50, which was unintuitive, so I set
an offset so that the bins are centered on multiples of 5, instead of
those being the borders.

For probability, I think breaks of 25 are more natural, and that
revealed that the bin at 50 was 45-50, which was unintuitive, so I set
an offset so that the bins are centered on multiples of 5, instead of
those being the borders.
@cincodenada
Copy link
Author

cincodenada commented Jan 15, 2021

After looking more closely, there are a few ways to accomplish the same bins - bins=21 will also do it, so if that seems nicer, go for it. I think a bin centered on the breaks tells the story best, and it appears 21 bins are required to have a bin width of 5 to accomplish that, because the default is to center the bins on the min/max values, so there's an "extra" bin (since the first/last bins are each only half a bin). The effective binwidth in the existing chart is actually 5.26, I believe.

This is better than offset=-2.5 because it doesn't include the width
twice
I'm not sure why I originally added the offset, but it seems to be not
required
This is better I think
Actually, setting the min expansion to 0 is way better, so keep it.

This reverts commit c395dd7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant