Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

294: Improve breaks and bins for probability chart #33

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

294: Improve breaks and bins for probability chart #33

wants to merge 6 commits into from

Commits on Jan 15, 2021

  1. 294: Improve breaks and bins for probability chart 

    For probability, I think breaks of 25 are more natural, and that
revealed that the bin at 50 was 45-50, which was unintuitive, so I set
an offset so that the bins are centered on multiples of 5, instead of
those being the borders.
    @cincodenada
    cincodenada committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    b6756d6 View commit details
    Browse the repository at this point in the history

  2. Change config to center=0 

    This is better than offset=-2.5 because it doesn't include the width
twice
    @cincodenada
    cincodenada committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    981ecc5 View commit details
    Browse the repository at this point in the history

  3. Actually center=0 is the default 

    I'm not sure why I originally added the offset, but it seems to be not
required
    @cincodenada
    cincodenada committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    d914641 View commit details
    Browse the repository at this point in the history

  4. Expand top of plot so bar isn't cut off

    @cincodenada
    cincodenada committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    3ff31f2 View commit details
    Browse the repository at this point in the history

  5. Use expand_limits instead 

    This is better I think
    @cincodenada
    cincodenada committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    c395dd7 View commit details
    Browse the repository at this point in the history

  6. Revert "Use expand_limits instead" 

    Actually, setting the min expansion to 0 is way better, so keep it.

This reverts commit c395dd7.
    @cincodenada
    cincodenada committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    759fd5b View commit details
    Browse the repository at this point in the history