Improved Monitor&WD handling in DeviceBootloader #922
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a rare case of infinite wait time upon creation of Device (or DeviceBootloader), if a device had an connectivity/booting issue
Diff is rather large due to the main "try catch" block adding identation, but it boils down to spinning up the Monitor&WD combo between each BL interaction, not just upon connecting to the main BL.
Bug was easily reproducible by placing a 5s sleep between:
Then boot device, wait for sleep section and disconnect before "requestVersion".
Affected mostly ETH based devices