-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encrypt patient data at rest and in backup files. #251
Open
schuyler
wants to merge
13
commits into
dev
Choose a base branch
from
schuyler/mariadb-encryption
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended for use with the Buendia system key.
Specifically for encryption support.
Essentially, ensure that openmrs.zip and buendia.tar.gz are encrypted using the Buendia system key. The patient chart ZIP is already encrypted with the OpenMRS server password, so we're leaving that untouched for now.
before decrypting. This will hopefully minimize the risk of running out of space on the backup storage device, since the decryption process has to make a copy of the output on disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes a few things:
/usr/share/buendia/system.key
that is created if not already present duringbuendia-utils
postinstall.buendia-mysql
to use this secret to encrypt a separate set of database keys, and updates the database dependency to MariaDB > 10.1.4 to guarantee that AES-CTR encryption-at-rest is available.buendia-backup
to use the system key to encrypt OpenMRS and Buendia configuration data on backup, and to decrypt with same on restore.buendia-backup
to backup and restore the system key itself to an external storage device, whenever an external device is used for backup or restore.This PR lays the groundwork for the security reset mode as described in #250 .
The encryption-at-rest, backup, and restore functions are all tested to some extent in integration tests that work in Vagrant. I've tested this functionality manually both on a fresh Vagrant system, and as an upgrade to an existing Vagrant system.